|
I'd say that's actually pretty good as an intro riff. Reminds me a lot of the demostyle melodies I used to hear. If it were my project, then for the "meat" of the song, I'd take that 2-bar phrase and extend it to an 8-bar phrase.
What makes a good melody is pretty subjective, but here's a super-abridged overview of what we learn in Harmony & Counterpoint (I'm assuming you have a good understanding of keys and intervals):
- Melodies should move in small steps as much as possible (no more than a 3rd);
- When a melody "leaps", it usually takes a small step or two in the opposite direction first;
- Don't use the tritone (i.e. C to F#) unless you're really sure of what you're doing;
- Melodies should return to the note they started on; the best overall "shape", at least for a classical-style (or trance) melody, is usually a simple up-down curve; if not a simple curve, a melody should visually be as smooth (as opposed to jagged or zig-zaggy) as possible;
- If you're writing a counterpoint (i.e. two melodies), you want them moving in opposite directions as much as possible, and definitely avoid parallel 5ths or octaves.
Of course, you'll end up with damn bland baroque-sounding melodies if you follow these rules to the letter - they're more like loose guidelines, and if you're working on jazz or funk melodies then the rules are completely different and take forever to learn.
I'm no expert at melody-writing, but I find that knowing the "rules" does help sometimes, in particular when you're feeling stumped. Hope that helps... apologies if I'm just telling you what you already know 
___________________
My party schedule:
2009-02-21 - DJ Attention @ I'm So Popular
2009-06-18 - DJ Annoying @ People Need To Know Where I'll Be
2012-11-32 - DJ Insufferable ɸ Or At Least the Stalkers I Complain About
2048-06-66 - Spastic & Whocares ¶ Although I'm Actually Flattered
9999-45-81 - Tweaker Gimp ☼ I Probably Won't Even Go To This But I Have To Make Sure I Fill Up All The Available Space Here
|